Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

file without closing ?> breaks production mode

#73

Omitting the closing ?> in a PHP file is legitimate (and defensible) PHP style. It causes no problems in development mode in recess but kills production mode, which blindly concatenates php files.

Reported by Joshua Paine · February 18th, 2009 @ 11:01 PM

State: resolved
Milestone: 0.20
Assigned to: Kris Jordan Kris Jordan

Activity

  1. Kris Jordan
    Kris Jordan
    • Milestone changed from 0.11.1 to 0.12
    • State changed from new to open

    This has been resolved in one of Jamie's commits. Need to pull the fix into Recess edge for 0.12 release.

    March 30th, 2009 @ 09:58 PM

  2. Kris Jordan
    Kris Jordan

    This has not been resolved in an existing commit. Simple solution would be to regex match <?php and ?>. More complicated case is that either is valid within a PHP string that could throw the check off.

    Could introduce a requirement for .class.php files that the opening characters of a file are <?php and the closing are ?>.

    March 31st, 2009 @ 12:10 PM

  3. Kris Jordan
    Kris Jordan
    • Milestone changed from 0.12 to 0.20

    Moving this back to 0.20 as there are other changes going on in Recess internals in 0.20 with optimizations in Library.

    March 31st, 2009 @ 03:38 PM

  4. Kris Jordan
    Kris Jordan
    • State changed from open to resolved

    Joshua Paine corrected this issue and it is in the source tree.

    June 9th, 2009 @ 02:52 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.