#73 ✓resolved
Joshua Paine

file without closing ?> breaks production mode

Reported by Joshua Paine | February 18th, 2009 @ 11:01 PM | in 0.20

Omitting the closing ?> in a PHP file is legitimate (and defensible) PHP style. It causes no problems in development mode in recess but kills production mode, which blindly concatenates php files.

Comments and changes to this ticket

  • Kris Jordan

    Kris Jordan March 30th, 2009 @ 09:58 PM

    • Milestone changed from 0.11.1 to 0.12
    • State changed from “new” to “open”

    This has been resolved in one of Jamie's commits. Need to pull the fix into Recess edge for 0.12 release.

  • Kris Jordan

    Kris Jordan March 31st, 2009 @ 12:10 PM

    This has not been resolved in an existing commit. Simple solution would be to regex match <?php and ?>. More complicated case is that either is valid within a PHP string that could throw the check off.

    Could introduce a requirement for .class.php files that the opening characters of a file are <?php and the closing are ?>.

  • Kris Jordan

    Kris Jordan March 31st, 2009 @ 03:38 PM

    • Milestone changed from 0.12 to 0.20

    Moving this back to 0.20 as there are other changes going on in Recess internals in 0.20 with optimizations in Library.

  • Kris Jordan

    Kris Jordan June 9th, 2009 @ 02:52 PM

    • State changed from “open” to “resolved”

    Joshua Paine corrected this issue and it is in the source tree.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The Recess PHP Framework is an open source, full stack, RESTful PHP framework.

http://www.recessframework.org/

People watching this ticket

Pages